{"id":"CVE-2025-21682","revision":"5168ea0d55954aa2b439b8ef1b8ca2a5","records":[{"revision":"5168ea0d55954aa2b439b8ef1b8ca2a5","observedAt":"2026-10-23T15:48:27.903+00:00","statement":{"source":"cve-program","id":"CVE-2025-21682","aliases":[],"title":"eth: bnxt: always recalculate features after XDP clearing, fix null-deref","description":"In the Linux kernel, the following vulnerability has been resolved:\n\neth: bnxt: always recalculate features after XDP clearing, fix null-deref\n\nRecalculate features when XDP is detached.\n\nBefore:\n  # ip li set dev eth0 xdp obj xdp_dummy.bpf.o sec xdp\n  # ip li set dev eth0 xdp off\n  # ethtool -k eth0 | grep gro\n  rx-gro-hw: off [requested on]\n\nAfter:\n  # ip li set dev eth0 xdp obj xdp_dummy.bpf.o sec xdp\n  # ip li set dev eth0 xdp off\n  # ethtool -k eth0 | grep gro\n  rx-gro-hw: on\n\nThe fact that HW-GRO doesn't get re-enabled automatically is just\na minor annoyance. The real issue is that the features will randomly\ncome back during another reconfiguration which just happens to invoke\nnetdev_update_features(). The driver doesn't handle reconfiguring\ntwo things at a time very robustly.\n\nStarting with commit 98ba1d931f61 (\"bnxt_en: Fix RSS logic in\n__bnxt_reserve_rings()\") we only reconfigure the RSS hash table\nif the \"effective\" number of Rx rings has changed. If HW-GRO is\nenabled \"effective\" number of rings is 2x what user sees.\nSo if we are in the bad state, with HW-GRO re-enablement \"pending\"\nafter XDP off, and we lower the rings by / 2 - the HW-GRO rings\ndoing 2x and the ethtool -L doing / 2 may cancel each other out,\nand the:\n\n  if (old_rx_rings != bp->hw_resc.resv_rx_rings &&\n\ncondition in __bnxt_reserve_rings() will be false.\nThe RSS map won't get updated, and we'll crash with:\n\n  BUG: kernel NULL pointer dereference, address: 0000000000000168\n  RIP: 0010:__bnxt_hwrm_vnic_set_rss+0x13a/0x1a0\n    bnxt_hwrm_vnic_rss_cfg_p5+0x47/0x180\n    __bnxt_setup_vnic_p5+0x58/0x110\n    bnxt_init_nic+0xb72/0xf50\n    __bnxt_open_nic+0x40d/0xab0\n    bnxt_open_nic+0x2b/0x60\n    ethtool_set_channels+0x18c/0x1d0\n\nAs we try to access a freed ring.\n\nThe issue is present since XDP support was added, really, but\nprior to commit 98ba1d931f61 (\"bnxt_en: Fix RSS logic in\n__bnxt_reserve_rings()\") it wasn't causing major issues.","state":0,"publishedAt":"2025-01-31T11:25:42.16+00:00","modifiedAt":"2026-10-15T01:03:00.227+00:00","affected":[{"ecosystem":"Vendor product","name":"Linux","ranges":[],"versions":[],"rawVersionEvidence":"{\n                    \"product\": \"Linux\",\n                    \"vendor\": \"Linux\",\n                    \"defaultStatus\": \"unaffected\",\n                    \"repo\": \"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git\",\n                    \"programFiles\": [\n                        \"drivers/net/ethernet/broadcom/bnxt/bnxt.c\",\n                        \"drivers/net/ethernet/broadcom/bnxt/bnxt.h\",\n                        \"drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c\"\n                    ],\n                    \"versions\": [\n                        {\n                            \"version\": \"1054aee82321483dceabbb9b9e5d6512e8fe684b\",\n                            \"lessThan\": \"076a694a42ae3f0466bc6e4126050eeb7b7d299a\",\n                            \"status\": \"affected\",\n                            \"versionType\": \"git\"\n                        },\n                        {\n                            \"version\": \"1054aee82321483dceabbb9b9e5d6512e8fe684b\",\n                            \"lessThan\": \"90336fc3d6f5e716ac39a9ddbbde453e23a5aa65\",\n                            \"status\": \"affected\",\n                            \"versionType\": \"git\"\n                        },\n                        {\n                            \"version\": \"1054aee82321483dceabbb9b9e5d6512e8fe684b\",\n                            \"lessThan\": \"08831a894d18abfaabb5bbde7c2069a7fb41dd93\",\n                            \"status\": \"affected\",\n                            \"versionType\": \"git\"\n                        },\n                        {\n                            \"version\": \"1054aee82321483dceabbb9b9e5d6512e8fe684b\",\n                            \"lessThan\": \"f0aa6a37a3dbb40b272df5fc6db93c114688adcd\",\n                            \"status\": \"affected\",\n                            \"versionType\": \"git\"\n                        }\n                    ]\n                }"},{"ecosystem":"Vendor product","name":"Linux","ranges":[],"versions":[],"rawVersionEvidence":"{\n                    \"product\": \"Linux\",\n                    \"vendor\": \"Linux\",\n                    \"defaultStatus\": \"affected\",\n                    \"repo\": \"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git\",\n                    \"programFiles\": [\n                        \"drivers/net/ethernet/broadcom/bnxt/bnxt.c\",\n                        \"drivers/net/ethernet/broadcom/bnxt/bnxt.h\",\n                        \"drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c\"\n                    ],\n                    \"versions\": [\n                        {\n                            \"version\": \"4.16\",\n                            \"status\": \"affected\"\n                        },\n                        {\n                            \"version\": \"0\",\n                            \"lessThan\": \"4.16\",\n                            \"status\": \"unaffected\",\n                            \"versionType\": \"semver\"\n                        },\n                        {\n                            \"version\": \"6.1.167\",\n                            \"lessThanOrEqual\": \"6.1.*\",\n                            \"status\": \"unaffected\",\n                            \"versionType\": \"semver\"\n                        },\n                        {\n                            \"version\": \"6.6.130\",\n                            \"lessThanOrEqual\": \"6.6.*\",\n                            \"status\": \"unaffected\",\n                            \"versionType\": \"semver\"\n                        },\n                        {\n                            \"version\": \"6.12.11\",\n                            \"lessThanOrEqual\": \"6.12.*\",\n                            \"status\": \"unaffected\",\n                            \"versionType\": \"semver\"\n                        },\n                        {\n                            \"version\": \"6.13\",\n                            \"lessThanOrEqual\": \"*\",\n                            \"status\": \"unaffected\",\n                            \"versionType\": \"original_commit_for_fix\"\n                        }\n                    ]\n                }"}],"metrics":[{"system":"CVSS 3.1","vector":"CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:H/I:L/A:H","score":7.3,"severity":"HIGH"}],"references":["https://git.kernel.org/stable/c/076a694a42ae3f0466bc6e4126050eeb7b7d299a","https://git.kernel.org/stable/c/90336fc3d6f5e716ac39a9ddbbde453e23a5aa65","https://git.kernel.org/stable/c/08831a894d18abfaabb5bbde7c2069a7fb41dd93","https://git.kernel.org/stable/c/f0aa6a37a3dbb40b272df5fc6db93c114688adcd"],"sourceUrl":"https://www.cve.org/CVERecord?id=CVE-2025-21682","license":"CVE Program Terms of Use","key":"cve-program:CVE-2025-21682","identifiers":["CVE-2025-21682"]},"retained":false,"historicalAffected":[]}],"coverage":[]}