{"id":"GHSA-j4r7-8ph4-43g3","revision":null,"records":[{"revision":"6271b011e25540dc8a15ea2c11baf4ea","observedAt":"2026-10-24T13:17:17.793+00:00","statement":{"source":"osv","id":"GHSA-j4r7-8ph4-43g3","aliases":[],"title":"faf-mcp has an arbitrary local file read/write via unconfined `path` argument in FAF tools","description":"### Summary\n`faf-mcp` MCP tools accept a caller-controlled `path` argument and resolve it (`~` expansion + `path.resolve()`) straight into a filesystem read/write **without confining it to a trusted project directory**. An absolute path or `../` traversal is resolved and used as-is, so the server process can be made to read — and, via the file tools, write — files outside the intended `.faf` project context. The only remaining limit is OS file permissions.\n\n### Affected tools\nThe shared `getProjectPath()` chokepoint (feeding the `.faf` tools) and the general-purpose `faf_read` / `faf_write` file tools resolved a caller path straight into a read/write with no confinement (denylist-only); an absolute path still reached home-directory secrets, and `faf_write` could write outside the project.\n\n### Impact\nAn MCP client — or an LLM prompt-injected via attacker-controlled content (a web page, README, ticket, or `.faf`) into issuing a tool call — can read any file the server process can read: SSH keys (`~/.ssh/id_rsa`), cloud credentials (`~/.aws/credentials`), `.env` files, source, `/etc/passwd`; and `faf_write` could write outside the project. This is a sensitive-information-disclosure (CWE-200) primitive that far exceeds the declared `.faf` project-context scope. The server runs over stdio, so the read/write is reached by a crafted tool call (e.g. a prompt-injected agent processing attacker-controlled content).\n\n### Patches\nFixed in **2.1.3** by confining every caller-supplied `path` before any filesystem access (`safe-path.ts`):\n- Reads are restricted to `.faf` / `.fafm` context files, so non-context files (secrets) are refused regardless of directory.\n- General file ops (`faf_read` / `faf_write`) are confined to the project root (cwd + system temp; override with `FAF_ALLOWED_ROOTS`).\n- Paths are canonicalized through symlinks (closing the symlink bypass); absolute paths and `../` escapes are rejected; `callTool()` gains a central PATH-DENIED guard.\n\nUpgrade: `npm install -g faf-mcp@2.1.3` (or `npx faf-mcp`).\n\n### Workarounds\nIf you cannot upgrade immediately, run the server only against trusted local projects, and set `FAF_ALLOWED_ROOTS` (patched versions) to a single project directory for a hard directory boundary.\n\n### Credits\nIdentified by the maintainers during a sibling-server audit prompted by the coordinated disclosure of the same class of issue in `grok-faf-mcp` by **Zhihao Zhang** (Worcester Polytechnic Institute).","state":0,"publishedAt":"2026-08-19T19:15:13+00:00","modifiedAt":"2026-08-19T19:30:06.6620391+00:00","affected":[{"ecosystem":"npm","name":"faf-mcp","ranges":[{"type":"SEMVER","events":[{"kind":"introduced","version":"0"},{"kind":"fixed","version":"2.1.3"}]}],"versions":[],"rawVersionEvidence":null}],"metrics":[{"system":"CVSS_V3","vector":"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N","score":null,"severity":null},{"system":"Publisher rating","vector":null,"score":null,"severity":"HIGH"}],"references":["https://github.com/Wolfe-Jam/faf-mcp/security/advisories/GHSA-j4r7-8ph4-43g3","https://github.com/Wolfe-Jam/faf-mcp","https://github.com/Wolfe-Jam/faf-mcp/releases/tag/v2.1.3"],"sourceUrl":"https://github.com/advisories/GHSA-j4r7-8ph4-43g3","license":"GitHub Advisory Database · CC-BY-4.0","key":"osv:GHSA-j4r7-8ph4-43g3","identifiers":["GHSA-j4r7-8ph4-43g3"]},"retained":false,"historicalAffected":[]}],"coverage":[{"source":"cisa-kev:global","scope":"Complete CISA KEV catalog; all vendors. Missing entries do not establish absence of exploitation.","generation":"2026-11-21T06:46:06.7239797+00:00","complete":true,"records":1790,"lastAttemptAt":"2026-11-21T06:46:06.7239797+00:00","lastSuccessAt":"2026-11-21T06:46:06.8985683+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.8985692+00:00","snapshotPublishedAt":null,"importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null},{"source":"cve-program","scope":"Official CVE Program baseline and cumulative hourly delta; all vendors, published and rejected records","generation":"cve-1d6c61c44cf3e269b6d60ed2fe0a3aa1f7e55445c7f170f16f2fa063bbf73db3-a9b98c6fcfe5d003ac2fa90e46da3ad639b2bd563f89873997692258b3bb0ea1","complete":true,"records":430062,"lastAttemptAt":"2026-11-21T06:46:06.039514+00:00","lastSuccessAt":"2026-11-21T06:46:06.0064127+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.039514+00:00","snapshotPublishedAt":"2026-11-21T06:27:10+00:00","importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null},{"source":"euvd","scope":"Rolling EUVD lookups of CVE aliases in current public OSV archives; 500 identifiers per refresh, rechecked after 48 hours. Not a global EUVD catalog. Successful not-found lookups count as checked; they do not imply withdrawal or safety. No reader inventory is sent.","generation":"enrichment-6560623440b841c2a9d6d091a27d7ce0","complete":false,"records":13919,"lastAttemptAt":"2026-11-21T06:53:14.8125353+00:00","lastSuccessAt":"2026-11-21T06:53:14.808+00:00","error":"117 identifier lookups failed; latest failures include AccessDenied (HTTP 403). Other identifiers were checked independently.","lastVerifiedAt":"2026-11-21T06:53:14.808+00:00","snapshotPublishedAt":null,"importing":false,"stagedRecords":0,"checkedIdentifiers":13850,"expectedIdentifiers":13967,"failedIdentifiers":117},{"source":"first-epss:nuget","scope":"FIRST EPSS for explicit CVE aliases in the collected public NuGet archive. Not a global EPSS backfill.","generation":"2026-11-21T06:46:06.7239797+00:00","complete":true,"records":1131,"lastAttemptAt":"2026-11-21T06:46:06.7239797+00:00","lastSuccessAt":"2026-11-21T06:46:06.8992975+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.8993013+00:00","snapshotPublishedAt":null,"importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null},{"source":"nvd","scope":"Rolling NVD lookups of CVE aliases in current public OSV archives; 500 identifiers per refresh, rechecked after 48 hours. Not a global NVD catalog. Successful not-found lookups count as checked; they do not imply withdrawal or safety. No reader inventory is sent.","generation":"enrichment-b466af56ae8f4061b064c38e0c70b535","complete":true,"records":13931,"lastAttemptAt":"2026-11-21T06:46:07.4258508+00:00","lastSuccessAt":"2026-11-21T04:46:11.167+00:00","error":null,"lastVerifiedAt":"2026-11-21T04:46:11.167+00:00","snapshotPublishedAt":null,"importing":false,"stagedRecords":0,"checkedIdentifiers":13967,"expectedIdentifiers":13967,"failedIdentifiers":0},{"source":"osv:Go","scope":"Complete OSV Go ecosystem archive, including withdrawn and malicious-package source records; statement counts are not unique CVE counts","generation":"go-99c78bee98bf8a60587f33f568944b12d3afe17ecc41437c57b47e2204cce04d","complete":true,"records":9989,"lastAttemptAt":"2026-11-21T06:46:06.6771635+00:00","lastSuccessAt":"2026-11-21T00:54:34.963487+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.6771635+00:00","snapshotPublishedAt":"2026-11-21T00:03:07+00:00","importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null},{"source":"osv:NuGet","scope":"Complete OSV NuGet ecosystem archive, including GitHub Advisory Database records; NuGet version matching only","generation":"nuget-6ba2352decd0c95d34a1b50f642582aa34659ce946f552488f0a5cea4e0cc09a","complete":true,"records":2020,"lastAttemptAt":"2026-11-21T06:46:06.0966911+00:00","lastSuccessAt":"2026-11-20T15:46:15.4249619+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.0966911+00:00","snapshotPublishedAt":"2026-11-20T14:48:20+00:00","importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null},{"source":"osv:crates.io","scope":"Complete OSV crates.io ecosystem archive, including withdrawn and malicious-package source records; statement counts are not unique CVE counts","generation":"crates.io-2c09f95d48acb57436aa1dd2f0eec6f651dce8d1621b6978554be0f0b129faa4","complete":true,"records":3209,"lastAttemptAt":"2026-11-21T06:46:06.6894056+00:00","lastSuccessAt":"2026-11-20T23:48:55.8565941+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.6894056+00:00","snapshotPublishedAt":"2026-11-20T23:48:16+00:00","importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null},{"source":"osv:npm","scope":"Complete OSV npm ecosystem archive, including withdrawn and malicious-package source records; statement counts are not unique CVE counts","generation":"npm-14439d295cda6d6706536c3efcb7f193a982609cf031218db7fa9ef26fdcc725","complete":true,"records":232850,"lastAttemptAt":"2026-11-21T06:46:06.5729118+00:00","lastSuccessAt":"2026-11-21T03:47:49.8245357+00:00","error":null,"lastVerifiedAt":"2026-11-21T06:46:06.5729118+00:00","snapshotPublishedAt":"2026-11-21T03:33:18+00:00","importing":false,"stagedRecords":0,"checkedIdentifiers":null,"expectedIdentifiers":null,"failedIdentifiers":null}]}