{"id":"RUSTSEC-2024-0359","revision":"194343d13bed43709deea1f604979e39","records":[{"revision":"194343d13bed43709deea1f604979e39","observedAt":"2026-10-24T13:19:54.901+00:00","statement":{"source":"osv","id":"RUSTSEC-2024-0359","aliases":["GHSA-cx7h-h87r-jpgr"],"title":"The kstring integration in gix-attributes is unsound","description":"`gix-attributes` (in [`state::ValueRef`](https://github.com/Byron/gitoxide/blob/gix-attributes-v0.22.2/gix-attributes/src/state.rs#L19-L27)) unsafely creates a `&str` from a `&[u8]` containing non-UTF8 data, with the justification that so long as nothing reads the `&str` and relies on it being UTF-8 in the `&str`, there is no UB:\n\n```rust\n// SAFETY: our API makes accessing that value as `str` impossible, so illformed UTF8 is never exposed as such.\n```\n\nThe problem is that the non-UTF8 `str` **is** exposed to outside code: first to the `kstring` crate itself, which requires UTF-8 in its documentation and may have UB as a consequence of this, but also to `serde`, where it propagates to e.g. `serde_json`, `serde_yaml`, etc., where the same problems occur.\n\nThis is not sound, and it could cause further UB down the line in these places that can view the `&str`.\n\n*Thanks to [Devin Jeanpierre](https://github.com/ssbr) for discovering and reporting this issue.*","state":0,"publishedAt":"2024-07-24T12:00:00+00:00","modifiedAt":"2025-01-19T00:59:32.710269+00:00","affected":[{"ecosystem":"crates.io","name":"gix-attributes","ranges":[{"type":"SEMVER","events":[{"kind":"introduced","version":"0.0.0-0"},{"kind":"fixed","version":"0.22.3"}]}],"versions":[],"rawVersionEvidence":null}],"metrics":[],"references":["https://crates.io/crates/gix-attributes","https://rustsec.org/advisories/RUSTSEC-2024-0359.html","https://github.com/GitoxideLabs/gitoxide/issues/1460"],"sourceUrl":"https://osv.dev/vulnerability/RUSTSEC-2024-0359","license":"OSV · upstream source license applies","key":"osv:RUSTSEC-2024-0359","identifiers":["RUSTSEC-2024-0359","GHSA-cx7h-h87r-jpgr"]},"retained":false,"historicalAffected":[]}],"coverage":[]}