Timing variability in `curve25519-dalek`'s `Scalar29::sub`/`Scalar52::sub`
Historical advisory saved 24 Oct 2026 13:19:54 UTC. The publisher may have updated it since then. Latest advisory.
osv · RUSTSEC-2024-0344
PublishedTiming variability of any kind is problematic when working with potentially secret values such as elliptic curve scalars, and such issues can potentially leak private keys and other secrets. Such a problem was recently discovered in `curve25519-dalek`. The `Scalar29::sub` (32-bit) and `Scalar52::sub` (64-bit) functions contained usage of a mask value inside a loop where LLVM saw an opportunity to insert a branch instruction (`jns` on x86) to conditionally bypass this code section when the mask value is set to zero as can be seen in godbolt: - 32-bit (see L106): <https://godbolt.org/z/zvaWxzvqv> - 64-bit (see L48): <https://godbolt.org/z/PczYj7Pda> A similar problem was recently discovered in the Kyber reference implementation: <https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/hqbtIGFKIpU/m/cnE3pbueBgAJ> As discussed on that thread, one portable solution, which is also used in this PR, is to introduce a volatile read as an optimization barrier, which prevents the compiler from optimizing it away. The fix can be validated in godbolt here: - 32-bit: <https://godbolt.org/z/jc9j7eb8E> - 64-bit: <https://godbolt.org/z/x8d46Yfah> The problem was discovered and the solution independently verified by Alexander Wagner <[email protected]> and Lea Themint <[email protected]> using their DATA tool: <https://github.com/Fraunhofer-AISEC/DATA>
- Source published
- 18 Jun 2024 12:00:00 UTC
- Source modified
- 28 Oct 2025 06:29:09 UTC
- Saved here
- 24 Oct 2026 13:19:54 UTC
- Source terms
- OSV · upstream source license applies
Original source record · Cite this exact observation · Complete original publisher JSON
Source: osv · OSV · upstream source license applies. The publisher's wording is preserved. ChangeIntel groups the information and labels changes. The JSON record includes additional source fields.