Public mode

No access to your tenant or devices. Every item links to its source. What this means

Sources need attention Customize Public modeDiscuss ChangeIntel on Discord

Subdomain checking of whitelisted domains could allow unintended redirects

CVSS 3.1 4.7 MEDIUMEUVD CVSS 3.1 4.7 CVSS 3.1 · [email protected] · Secondary 4.7 MEDIUMCVSS 3.1 · [email protected] · Primary 6.1 MEDIUMCVSS 2.0 · [email protected] · Primary 5.8 MEDIUMCVSS_V3 Publisher rating LOWFixed by github.com/oauth2-proxy/oauth2-proxy/v7 7.0.0osv · severity unknownFixed by github.com/oauth2-proxy/oauth2-proxy/v7 7.0.0KEV status unknown

cve-program · CVE-2021-21291

Published

OAuth2 Proxy is an open-source reverse proxy and static file server that provides authentication using Providers (Google, GitHub, and others) to validate accounts by email, domain or group. In OAuth2 Proxy before version 7.0.0, for users that use the whitelist domain feature, a domain that ended in a similar way to the intended domain could have been allowed as a redirect. For example, if a whitelist domain was configured for ".example.com", the intention is that subdomains of example.com are allowed. Instead, "example.com" and "badexample.com" could also match. This is fixed in version 7.0.0 onwards. As a workaround, one can disable the whitelist domain feature and run separate OAuth2 Proxy instances for each subdomain.

Read the publisher's advisory

euvd · EUVD-2021-0944

Published

OAuth2 Proxy is an open-source reverse proxy and static file server that provides authentication using Providers (Google, GitHub, and others) to validate accounts by email, domain or group. In OAuth2 Proxy before version 7.0.0, for users that use the whitelist domain feature, a domain that ended in a similar way to the intended domain could have been allowed as a redirect. For example, if a whitelist domain was configured for ".example.com", the intention is that subdomains of example.com are allowed. Instead, "example.com" and "badexample.com" could also match. This is fixed in version 7.0.0 onwards. As a workaround, one can disable the whitelist domain feature and run separate OAuth2 Proxy instances for each subdomain.

Read the publisher's advisory

nvd · CVE-2021-21291

Published

OAuth2 Proxy is an open-source reverse proxy and static file server that provides authentication using Providers (Google, GitHub, and others) to validate accounts by email, domain or group. In OAuth2 Proxy before version 7.0.0, for users that use the whitelist domain feature, a domain that ended in a similar way to the intended domain could have been allowed as a redirect. For example, if a whitelist domain was configured for ".example.com", the intention is that subdomains of example.com are allowed. Instead, "example.com" and "badexample.com" could also match. This is fixed in version 7.0.0 onwards. As a workaround, one can disable the whitelist domain feature and run separate OAuth2 Proxy instances for each subdomain.

Read the publisher's advisory

osv · GHSA-4mf2-f3wh-gvf2

Published

### Impact _What kind of vulnerability is it? Who is impacted?_ For users that use the whitelist domain feature, a domain that ended in a similar way to the intended domain could have been allowed as a redirect. For example, if a whitelist domain was configured for `.example.com`, the intention is that subdomains of `example.com` are allowed. Instead, `example.com` and `badexample.com` could also match. ### Patches _Has the problem been patched? What versions should users upgrade to?_ This is fixed in version 7.0.0 onwards. ### Workarounds _Is there a way for users to fix or remediate the vulnerability without upgrading?_ Disable the whitelist domain feature and run separate OAuth2 Proxy instances for each subdomain. # Original Issue Posted by @semoac: Whitelist Domain feature is not working as expected because is not matching a dot to ensure the redirect is a subdomain. ## Expected Behavior If whitelist domain is set to `.example.com` , then `hack.alienexample.com` should be rejected as a valid redirect. ## Current Behavior The code is removing the `dot` from `.example.com` and only checking if the redirect string end with `example.com` ## Possible Solution Here https://github.com/oauth2-proxy/oauth2-proxy/blob/c377466411f2aee180a732187edb638f2f7e57fb/oauthproxy.go#L661 Include the dot when checking the string: ``` strings.HasSuffix(redirectHostname, "." + domainHostname) ``` ## Steps to Reproduce (for bugs) ``` package main import ( "fmt" "strings" ) func validOptionalPort(port string) bool { if port == "" || port == ":*" { return true } if port[0] != ':' { return false } for _, b := range port[1:] { if b < '0' || b > '9' { return false } } return true } func splitHostPort(hostport string) (host, port string) { host = hostport colon := strings.LastIndexByte(host, ':') if colon != -1 && validOptionalPort(host[colon:]) { host, port = host[:colon], host[colon+1:] } if strings.HasPrefix(host, "[") && strings.HasSuffix(host, "]") { host = host[1 : len(host)-1] } return } func main() { domain := ".example.com" domainHostname, _ := splitHostPort(strings.TrimLeft(domain, ".")) redirectHostname := "https://hack.alienexample.com" if (strings.HasPrefix(domain, ".") && strings.HasSuffix(redirectHostname, domainHostname)) { fmt.Println("This should not have happen.")} } ``` Users of `github.com/oauth2-proxy/oauth2-proxy` are advised to update to `github.com/oauth2-proxy/oauth2-proxy/v7`

Read the publisher's advisory

osv · GO-2022-0790

Published

Subdomain checking of whitelisted domains could allow unintended redirects in oauth2-proxy in github.com/oauth2-proxy/oauth2-proxy

Read the publisher's advisory

Affected versions, risk and source history

Related advisories and sources

Publishers link these advisories through the identifiers shown below. A shared identifier or date alone does not tell you whether your software is affected or whether the advisories describe the same cause.

CVE-2021-21291 · CVE overview and exploitation status

EUVD-2021-0944

GHSA-4mf2-f3wh-gvf2

BIT-oauth2-proxy-2021-21291

GO-2022-0790

cve-program · CVE-2021-21291

euvd · EUVD-2021-0944

nvd · CVE-2021-21291

osv · GHSA-4mf2-f3wh-gvf2

osv · GO-2022-0790

Related changes

Linked by CVE identifier

No related changes are available here.

ChangeIntel

An IT change radar: releases, security, known issues, retirements, documentation changes, and service status from public sources. Every item links to supporting evidence; dates and statuses can change after they are read.

Sources read 19 Nov 05:53 UTC · 273 of 275 readable · 269 fully read · documentation 469/469 current