curve25519-dalek · Vulnerability
cve-program · CVE-2024-58262
PublishedThe curve25519-dalek crate before 4.1.3 for Rust has a constant-time operation on elliptic curve scalars that is removed by LLVM.
Read the publisher's advisoryeuvd · EUVD-2024-54823
PublishedThe curve25519-dalek crate before 4.1.3 for Rust has a constant-time operation on elliptic curve scalars that is removed by LLVM.
Read the publisher's advisorynvd · CVE-2024-58262
PublishedThe curve25519-dalek crate before 4.1.3 for Rust has a constant-time operation on elliptic curve scalars that is removed by LLVM.
Read the publisher's advisoryosv · GHSA-x4gp-pqpj-f43q
PublishedTiming variability of any kind is problematic when working with potentially secret values such as elliptic curve scalars, and such issues can potentially leak private keys and other secrets. Such a problem was recently discovered in `curve25519-dalek`. The `Scalar29::sub` (32-bit) and `Scalar52::sub` (64-bit) functions contained usage of a mask value inside a loop where LLVM saw an opportunity to insert a branch instruction (`jns` on x86) to conditionally bypass this code section when the mask value is set to zero as can be seen in godbolt: - 32-bit (see L106): https://godbolt.org/z/zvaWxzvqv - 64-bit (see L48): https://godbolt.org/z/PczYj7Pda A similar problem was recently discovered in the Kyber reference implementation: https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/hqbtIGFKIpU/m/cnE3pbueBgAJ As discussed on that thread, one portable solution, which is also used in this PR, is to introduce a volatile read as an optimization barrier, which prevents the compiler from optimizing it away. The fix can be validated in godbolt here: - 32-bit: https://godbolt.org/z/jc9j7eb8E - 64-bit: https://godbolt.org/z/x8d46Yfah The problem was discovered and the solution independently verified by Alexander Wagner <[email protected]> and Lea Themint <[email protected]> using their DATA tool: https://github.com/Fraunhofer-AISEC/DATA
Read the publisher's advisoryosv · RUSTSEC-2024-0344
PublishedTiming variability of any kind is problematic when working with potentially secret values such as elliptic curve scalars, and such issues can potentially leak private keys and other secrets. Such a problem was recently discovered in `curve25519-dalek`. The `Scalar29::sub` (32-bit) and `Scalar52::sub` (64-bit) functions contained usage of a mask value inside a loop where LLVM saw an opportunity to insert a branch instruction (`jns` on x86) to conditionally bypass this code section when the mask value is set to zero as can be seen in godbolt: - 32-bit (see L106): <https://godbolt.org/z/zvaWxzvqv> - 64-bit (see L48): <https://godbolt.org/z/PczYj7Pda> A similar problem was recently discovered in the Kyber reference implementation: <https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/hqbtIGFKIpU/m/cnE3pbueBgAJ> As discussed on that thread, one portable solution, which is also used in this PR, is to introduce a volatile read as an optimization barrier, which prevents the compiler from optimizing it away. The fix can be validated in godbolt here: - 32-bit: <https://godbolt.org/z/jc9j7eb8E> - 64-bit: <https://godbolt.org/z/x8d46Yfah> The problem was discovered and the solution independently verified by Alexander Wagner <[email protected]> and Lea Themint <[email protected]> using their DATA tool: <https://github.com/Fraunhofer-AISEC/DATA>
Read the publisher's advisoryAffected versions, risk and source history
Related advisories and sources
Publishers link these advisories through the identifiers shown below. A shared identifier or date alone does not tell you whether your software is affected or whether the advisories describe the same cause.
CVE-2024-58262 · CVE overview and exploitation status
cve-program · CVE-2024-58262
- https://rustsec.org/advisories/RUSTSEC-2024-0344.html
- https://github.com/dalek-cryptography/curve25519-dalek/pull/659
- https://crates.io/crates/curve25519-dalek
euvd · EUVD-2024-54823
- https://rustsec.org/advisories/RUSTSEC-2024-0344.html
- https://github.com/dalek-cryptography/curve25519-dalek/pull/659
- https://crates.io/crates/curve25519-dalek
nvd · CVE-2024-58262
- https://crates.io/crates/curve25519-dalek
- https://github.com/dalek-cryptography/curve25519-dalek/pull/659
- https://rustsec.org/advisories/RUSTSEC-2024-0344.html
osv · GHSA-x4gp-pqpj-f43q
- https://nvd.nist.gov/vuln/detail/CVE-2024-58262
- https://github.com/dalek-cryptography/curve25519-dalek/pull/659
- https://github.com/dalek-cryptography/curve25519-dalek/commit/415892acf1cdf9161bd6a4c99bc2f4cb8fae5e6a
- https://github.com/dalek-cryptography/curve25519-dalek
- https://rustsec.org/advisories/RUSTSEC-2024-0344.html
osv · RUSTSEC-2024-0344
Related changes
Linked by CVE identifierNo related changes are available here.