Russh is missing an overflow check during channel windows adjust
cve-program · CVE-2025-54804
PublishedRussh is a Rust SSH client & server library. In versions 0.54.0 and below, the channel window adjust message of the SSH protocol is used to track the free space in the receive buffer of the other side of a channel. The current implementation takes the value from the message and adds it to an internal state value. This can result in a integer overflow. If the Rust code is compiled with overflow checks, it will panic. A malicious client can crash a server. This is fixed in version 0.54.1.
Read the publisher's advisoryeuvd · EUVD-2025-23576
PublishedRussh is a Rust SSH client & server library. In versions 0.54.0 and below, the channel window adjust message of the SSH protocol is used to track the free space in the receive buffer of the other side of a channel. The current implementation takes the value from the message and adds it to an internal state value. This can result in a integer overflow. If the Rust code is compiled with overflow checks, it will panic. A malicious client can crash a server. This is fixed in version 0.54.1.
Read the publisher's advisorynvd · CVE-2025-54804
PublishedRussh is a Rust SSH client & server library. In versions 0.54.0 and below, the channel window adjust message of the SSH protocol is used to track the free space in the receive buffer of the other side of a channel. The current implementation takes the value from the message and adds it to an internal state value. This can result in a integer overflow. If the Rust code is compiled with overflow checks, it will panic. A malicious client can crash a server. This is fixed in version 0.54.1.
Read the publisher's advisoryosv · GHSA-h5rc-j5f5-3gcm
Published### Summary The channel window adjust message of the SSH protocol is used to track the free space in the receive buffer of the other side of a channel. The current implementation takes the value from the message and adds it to an internal state value. This can result in a integer overflow. If the Rust code is compiled with overflow checks, it will panic. A malicious client can crash a server. ### Details According https://datatracker.ietf.org/doc/html/rfc4254#section-5.2, The value must not overflow. The incorrect handling is done in server/encrypted.rs and client/encrypted.rs in the handling of CHANNEL_WINDOW_ADJUST. ``` let amount = map_err!(u32::decode(&mut r))?; ... channel.recipient_window_size += amount; ``` It could be replaced with something like ``` if let Some(ref mut channel) = enc.channels.get_mut(&channel_num) { // rfc 4254: The window MUST NOT be increased above 2^32 - 1 bytes. new_size = channel.recipient_window_size.saturating_add(amount); channel.recipient_window_size = new_size; } ... ``` ### PoC A customized client code would be required to send a message with a big value like u32_max. Not done yet. ### Impact This problem seems only critical to a server. One user can crash the server, which might take down the service. A malicious server could also crash a single client, but this seems not very critical.
Read the publisher's advisoryAffected versions, risk and source history
Related advisories and sources
Publishers link these advisories through the identifiers shown below. A shared identifier or date alone does not tell you whether your software is affected or whether the advisories describe the same cause.
CVE-2025-54804 · CVE overview and exploitation status
cve-program · CVE-2025-54804
- https://github.com/Eugeny/russh/security/advisories/GHSA-h5rc-j5f5-3gcm
- https://github.com/Eugeny/russh/commit/0eb5e406780890e21ff71dd25d731b30676478e5
euvd · EUVD-2025-23576
- https://github.com/Eugeny/russh/security/advisories/GHSA-h5rc-j5f5-3gcm
- https://github.com/Eugeny/russh/commit/0eb5e406780890e21ff71dd25d731b30676478e5
nvd · CVE-2025-54804
- https://github.com/Eugeny/russh/commit/0eb5e406780890e21ff71dd25d731b30676478e5
- https://github.com/Eugeny/russh/security/advisories/GHSA-h5rc-j5f5-3gcm
osv · GHSA-h5rc-j5f5-3gcm
Related changes
Linked by CVE identifierNo related changes are available here.